Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Affinity ChangeOnFailure should be boolean #4166

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

  • Use GetBoolAnnotation helper instead of GetStringAnnotation and verifying manually using Regexp

  • Fix variable naming

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei June 6, 2019 15:24
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c6c6f51). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4166   +/-   ##
=========================================
  Coverage          ?   57.63%           
=========================================
  Files             ?       87           
  Lines             ?     6463           
  Branches          ?        0           
=========================================
  Hits              ?     3725           
  Misses            ?     2307           
  Partials          ?      431
Impacted Files Coverage Δ
internal/ingress/types.go 0% <ø> (ø)
...ternal/ingress/annotations/sessionaffinity/main.go 55.26% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c6f51...83f2acb. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d460147 into kubernetes:master Jun 6, 2019
@ElvinEfendi ElvinEfendi deleted the use-correct-type branch July 8, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants