feature(collectors): Added services to collectorLabels

[semoac]

Added services to collectorLabels and requests Countervec to capture the name of the kubernetes services used to serve the client request.

What this PR does / why we need it:

It's add the string "service" to the colelctorLabels so the total number of client requests also includes the service used to serve that request.
This adds better support for more details telemetry, something useful (and needed) when using this information to trigger autoscalling policies on different deployments inside Kubernetes.
With this change, and little effort, you can use Prometheus/Grafana or Datadog to display the requests per seconds and error codes for every service on your cluster.

Special notes for your reviewer:
This change was based on the tag nginx-0.24.1

[k8s-ci-robot]

Welcome @semoac!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @semoac. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[semoac]

Hi,

Does this PR need something else to be reviewed?

Cheers.

[aledbf]

@semoac I am reluctant to keep adding new labels to the metrics. We need to review and refactor the metrics, but we delayed that for several releases. I will add the feature you want to add to the list of items for the refactoring.

Edit: that said, I will test the PR and try to include it in the next release

[aledbf]

/ok-to-test

[aledbf]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, semoac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

@semoac thanks!