-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor whitelist from map to standard allow directives #4101
Conversation
a6c12ab
to
22c3e86
Compare
22c3e86
to
3ee9e00
Compare
3ee9e00
to
c459752
Compare
Codecov Report
@@ Coverage Diff @@
## master #4101 +/- ##
=======================================
Coverage 57.76% 57.76%
=======================================
Files 87 87
Lines 6459 6459
=======================================
Hits 3731 3731
Misses 2296 2296
Partials 432 432 Continue to review full report at Codecov.
|
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Changes whitelist from a map to standard allow/deny directives.
After this PR I will add a new validation to the webhook to detect when the user defined a snippet containing the satisfy directive to avoid duplications