Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor whitelist from map to standard allow directives #4101

Merged
merged 2 commits into from
May 27, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 18, 2019

What this PR does / why we need it:

Changes whitelist from a map to standard allow/deny directives.

After this PR I will add a new validation to the webhook to detect when the user defined a snippet containing the satisfy directive to avoid duplications

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and ElvinEfendi May 18, 2019 10:01
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2019
@aledbf aledbf force-pushed the reftactor-whitelist branch from a6c12ab to 22c3e86 Compare May 18, 2019 10:05
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2019
@aledbf aledbf force-pushed the reftactor-whitelist branch from 22c3e86 to 3ee9e00 Compare May 22, 2019 12:00
@aledbf aledbf force-pushed the reftactor-whitelist branch from 3ee9e00 to c459752 Compare May 27, 2019 08:55
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2019
@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #4101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4101   +/-   ##
=======================================
  Coverage   57.76%   57.76%           
=======================================
  Files          87       87           
  Lines        6459     6459           
=======================================
  Hits         3731     3731           
  Misses       2296     2296           
  Partials      432      432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24cb0e5...c2227a0. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented May 27, 2019

/retest

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bf11e2e into kubernetes:master May 27, 2019
@aledbf aledbf deleted the reftactor-whitelist branch May 27, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants