-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs - Update capture group placeholder
#4099
Conversation
The current ingress example uses the `$2` capture group placeholder, however the description refers to the `$1` placeholder (this was previously correct, but was not updated when the ingress example changed from $1 to $2).
Hi @kppullin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@kppullin thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, kppullin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4099 +/- ##
=========================================
Coverage ? 57.67%
=========================================
Files ? 87
Lines ? 6450
Branches ? 0
=========================================
Hits ? 3720
Misses ? 2300
Partials ? 430 Continue to review full report at Codecov.
|
What this PR does / why we need it:
In the rewrite doc, the current ingress example uses the
$2
capture group placeholder, however the description refers to the$1
placeholder (this was previously correct, but was not updated when the ingress example changed from $1 to $2).