-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configmap about adding custom locations #4098
Conversation
Welcome @kevinsimper! |
Hi @kevinsimper. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@kevinsimper thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, kevinsimper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov Report
@@ Coverage Diff @@
## master #4098 +/- ##
=========================================
Coverage ? 57.72%
=========================================
Files ? 87
Lines ? 6450
Branches ? 0
=========================================
Hits ? 3723
Misses ? 2297
Partials ? 430 Continue to review full report at Codecov.
|
I tried using server-snippet and location-snippet to add a custom location, like this in 0.24.1:
but that didn't work, I got 503, and I tried copying in the exact location, but then the nginx configuration doesn't load, and the last solution was to make my own nginx.tmpl and that worked.
It looks like others also have experienced the same and this feature has stopped working: #4084 (comment)
It would be cool if you could avoid having to inherit the whole nginx.tmpl., but it is not bad, but it is just a bit of inconvenience to have to try the whole ordeal by providing your small customization with a location snippet and then debugging 😃