Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Prow #4088

Merged
merged 9 commits into from
May 17, 2019
Merged

Migrate to Prow #4088

merged 9 commits into from
May 17, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 15, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and ElvinEfendi May 15, 2019 15:23
@aledbf aledbf force-pushed the prow branch 3 times, most recently from 4eb7090 to 453af19 Compare May 15, 2019 21:11
@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #4088 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4088      +/-   ##
==========================================
- Coverage   57.78%   57.72%   -0.07%     
==========================================
  Files          87       87              
  Lines        6438     6450      +12     
==========================================
+ Hits         3720     3723       +3     
- Misses       2288     2297       +9     
  Partials      430      430
Impacted Files Coverage Δ
internal/ingress/zz_generated.deepcopy.go 0% <0%> (ø) ⬆️
internal/ingress/metric/collectors/process.go 90.42% <0%> (+2.12%) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182b282...d32079e. Read the comment docs.

@aledbf aledbf closed this May 17, 2019
@aledbf aledbf reopened this May 17, 2019
@aledbf
Copy link
Member Author

aledbf commented May 17, 2019

/retest

@ElvinEfendi
Copy link
Member

/lgtm

🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1bd3fd2 into kubernetes:master May 17, 2019
@aledbf aledbf deleted the prow branch May 22, 2019 13:51
@wayt wayt mentioned this pull request May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants