Don't try to create e2e runner rbac resources twice #4070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Every CI e2e run has this in its output:
This is because those resources are created in
make e2e-test
, and thentest/e2e-image/e2e.sh
tries to create them again.This doesn't make sense:
e2e.sh
is run in a container which uses that service account and binding. It can't create them, because it needs them to already exist. They have to be created in the make target, which then runs the container.Special notes for your reviewer: