Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to create e2e runner rbac resources twice #4070

Merged
merged 1 commit into from
May 8, 2019

Conversation

nicknovitski
Copy link
Contributor

What this PR does / why we need it:

Every CI e2e run has this in its output:

Error from server (AlreadyExists): serviceaccounts "ingress-nginx-e2e" already exists
Error from server (AlreadyExists): clusterrolebindings.rbac.authorization.k8s.io "permissive-binding" already exists
Running e2e test suite...

This is because those resources are created in make e2e-test, and then test/e2e-image/e2e.sh tries to create them again.

This doesn't make sense: e2e.sh is run in a container which uses that service account and binding. It can't create them, because it needs them to already exist. They have to be created in the make target, which then runs the container.

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and ElvinEfendi May 8, 2019 01:13
@aledbf
Copy link
Member

aledbf commented May 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@aledbf
Copy link
Member

aledbf commented May 8, 2019

@nicknovitski thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, nicknovitski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6d82cd6 into kubernetes:master May 8, 2019
@nicknovitski nicknovitski deleted the e2e-rbac-once branch May 8, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants