-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic ssl improvements #4000
Merged
k8s-ci-robot
merged 7 commits into
kubernetes:master
from
ElvinEfendi:dynamic-ssl-improvements
Apr 13, 2019
Merged
Dynamic ssl improvements #4000
k8s-ci-robot
merged 7 commits into
kubernetes:master
from
ElvinEfendi:dynamic-ssl-improvements
Apr 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Apr 12, 2019
k8s-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Apr 12, 2019
k8s-ci-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Apr 13, 2019
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Apr 13, 2019
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Apr 13, 2019
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In #3990 I was fixing the issue described in #3983 by making sure default certificate is being saved on disk. While this fixes the particular issue but it is not a good solution because for catch all ingress requests first Lua SSL handler will be called but it won't be able to do the handshake because the default certificate for catch all server is stored with key
_
however request SSL server name can be anything. It'll fallback using the Nginx's default SSL handler with the cert configured on filesystem.A better solution is to teach Lua SSL handler to properly handle default certificate and catch all ingress. And also dynamically handle default certificate. This is what the PR does:
Make sure controller properly sets
PemFileName
andPemSHA
for fake cert, default cert and as well as custom cert for a given ingerss. And properly here means always set those two fields to what we have in fake cert when dynamic cert mode is enabled.Change Lua SSL handler to fallback to fetching certificate using
_
when there's no cert could be obtained using SNI name.That means in dynamic mode every server block will always have only fake certificate configured in Nginx. The Lua side will handle all the other certs.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: