Update dependencies #3943
Merged
Update dependencies #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
ElvinEfendi
reviewed
Mar 28, 2019
| @@ -47,7 +47,7 @@ func main() { | |||
| } | |||
|
|
|||
| // Respect some basic kubectl flags like --namespace | |||
| flags := genericclioptions.NewConfigFlags() | |||
| flags := genericclioptions.NewConfigFlags(true) | |||
|
/lgtm |
k8s-ci-robot
added
the
lgtm
aledbf
force-pushed
the
update-dependencies
branch
from
bf251be to
91fdb8d
Compare
k8s-ci-robot
added
sig/cloud-provider
aledbf
force-pushed
the
update-dependencies
branch
from
91fdb8d to
bb2d19c
Compare
aledbf
force-pushed
the
update-dependencies
branch
from
bb2d19c to
14f4a7b
Compare
|
@ElvinEfendi now is ready |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
aledbf
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: