Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of a secret located in a different namespace #3875

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 9, 2019

What this PR does / why we need it:

In the docs we mention that ns/secret is allowed but not in the code https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#authentication

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

fixes #3493

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2019
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kfox1111
Copy link

This should have a flag to enable this functionality? Normally I don't want users to be able to reach across namespaces for secrets.

@aledbf
Copy link
Member Author

aledbf commented Mar 11, 2019

This should have a flag to enable this functionality? Normally I don't want users to be able to reach across namespaces for secrets.

This change only applies for the auth annotation and it's something already present. This PR just fixes a bug, not adding new features.

@aledbf
Copy link
Member Author

aledbf commented Mar 11, 2019

/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Mar 11, 2019
@aledbf aledbf removed the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8690958 into kubernetes:master Mar 11, 2019
@aledbf aledbf deleted the fix-auth-secret branch March 12, 2019 14:47
@zeph
Copy link

zeph commented Apr 3, 2020

@aledbf I'm on ingress-controller 0.27.1 and your patch populated sns for me, awesome, but still this feature is not working... i'm getting a no object matching key "<ns>/<secret>" in local store

@aledbf
Copy link
Member Author

aledbf commented Apr 3, 2020

@zeph please open a new issue. It would be great if you could include the steps to reproduce it.

@zeph
Copy link

zeph commented Apr 3, 2020

I copy pasted from here... https://kubernetes.github.io/ingress-nginx/examples/auth/basic/ xD

ok, I will...

@aledbf
Copy link
Member Author

aledbf commented Apr 3, 2020

@zeph just in case, I cannot reproduce what you describe following the example
https://gist.github.com/aledbf/4298bacb1487bf8084d4b2577dfb0a24

Edit: please make sure you are using the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading BasicDigestAuth annotation
5 participants