-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the use of a secret located in a different namespace #3875
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This should have a flag to enable this functionality? Normally I don't want users to be able to reach across namespaces for secrets. |
This change only applies for the auth annotation and it's something already present. This PR just fixes a bug, not adding new features. |
/shrug |
@aledbf I'm on ingress-controller |
@zeph please open a new issue. It would be great if you could include the steps to reproduce it. |
I copy pasted from here... https://kubernetes.github.io/ingress-nginx/examples/auth/basic/ xD ok, I will... |
@zeph just in case, I cannot reproduce what you describe following the example Edit: please make sure you are using the latest version |
What this PR does / why we need it:
In the docs we mention that ns/secret is allowed but not in the code https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#authentication
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):fixes #3493