Prevent e2e-tests from running on non-local clusters

[alexkursell]

Right now, if you run make e2e-test with your kubectl context set to some other cluster, it will dump a bunch of stuff into it. With this PR make e2e-test will only run if the context is a local one (currently just checking if it's one of minikube, kind, and docker-for-desktop).

Just putting up PR now to see how CI reacts.

[alexkursell]

I'm wondering whether or not there is a better way to do this. Just checking the context name against a few common strings seems hacky, and annoying if someone is using something different as they would have to edit the Makefile. Maybe the right thing to do would be to explicitly require a CONTEXT environment variable to run make e2e-test, so that you would have to type CONTEXT=minikube make e2e-test to run it. I'd be interested to hear suggestions.

[ElvinEfendi]

I think this will not age well - we can easily forget to add --context later when we decide to create anothe resource.

[ElvinEfendi]

@alexkursell wile hacky I liked your previous approach better. If we see it creates an extra friction for developers then maybe we can introduce an env variable like SKIP_CONTEXT_CHECK to skip that check but for now let's just whitelist those three contexts.

[alexkursell]

@ElvinEfendi fair enough. I've rolled back to that commit.

[ElvinEfendi]

@alexkursell squash the commits, looking good to me.

[aledbf]

/lgtm

[aledbf]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, alexkursell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment