Migrate e2e cluster to kind #3806
Merged
+70
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
aledbf
force-pushed
the
kind-e2e
branch
4 times, most recently
from
2e9a490 to
32e3980
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
aledbf
force-pushed
the
kind-e2e
branch
6 times, most recently
from
7f4e56d to
5870578
Compare
k8s-ci-robot
added
size/L
aledbf
force-pushed
the
kind-e2e
branch
2 times, most recently
from
32fad24 to
a2b4b79
Compare
aledbf
removed
the
do-not-merge/hold
|
@aledbf please add description how the migration is going to happen, what's gonna change if any, why is kind better, what we expect to gain? |
ElvinEfendi
reviewed
Mar 21, 2019
|
|
||
| export KUBECONFIG="$(kind get kubeconfig-path --name="${KIND_CLUSTER_NAME}")" | ||
|
|
||
| sleep 60 |
There was a problem hiding this comment.
Is this waiting for cluster creation? If so is it not better to do it ater line 32 inside the if block?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Migrates e2e testing from kubeadm-dind-cluster to kind
The main differences are:
There are no changes required to the e2e tests, just the bootstrap of the cluster.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: