-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua bridge tracer #3782
Lua bridge tracer #3782
Conversation
But there's no urgency to make this part of |
@ElvinEfendi how we use this? (I don't see a module for nginx) |
@aledbf it gets loaded dynamically as Lua module: https://github.com/opentracing/lua-bridge-tracer/blob/6354a7d7a179bcbb797957788b24f7267c6ccf39/CMakeLists.txt#L32 |
Codecov Report
@@ Coverage Diff @@
## master #3782 +/- ##
=======================================
Coverage 54.78% 54.78%
=======================================
Files 82 82
Lines 6120 6120
=======================================
Hits 3353 3353
Misses 2370 2370
Partials 397 397 Continue to review full report at Codecov.
|
/hold cancel |
After experimenting with this at #3783 I see no reason to not merge this now. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I'm not sure yet but I think it might be valuable to include some Lua traces as well (this will particularly be useful when we have Lua plugin system). For now I'm thinking we can create spans for each Nginx Lua phase, that way one can see how long does it take for a phase to run for given request.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: