Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua bridge tracer #3782

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Lua bridge tracer #3782

merged 2 commits into from
Feb 20, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
I'm not sure yet but I think it might be valuable to include some Lua traces as well (this will particularly be useful when we have Lua plugin system). For now I'm thinking we can create spans for each Nginx Lua phase, that way one can see how long does it take for a phase to run for given request.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2019
@ElvinEfendi
Copy link
Member Author

But there's no urgency to make this part of 0.23.0, maybe 0.24.0.
For now
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2019
@aledbf
Copy link
Member

aledbf commented Feb 20, 2019

@ElvinEfendi how we use this? (I don't see a module for nginx)

@ElvinEfendi
Copy link
Member Author

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2019
@ElvinEfendi ElvinEfendi mentioned this pull request Feb 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #3782 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3782   +/-   ##
=======================================
  Coverage   54.78%   54.78%           
=======================================
  Files          82       82           
  Lines        6120     6120           
=======================================
  Hits         3353     3353           
  Misses       2370     2370           
  Partials      397      397

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d5ef9...d2d160b. Read the comment docs.

@ElvinEfendi
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2019
@ElvinEfendi
Copy link
Member Author

After experimenting with this at #3783 I see no reason to not merge this now.

@aledbf
Copy link
Member

aledbf commented Feb 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c6676d into kubernetes:master Feb 20, 2019
@ElvinEfendi ElvinEfendi deleted the lua-bridge-tracer branch February 20, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants