feat: configurable proxy buffers number

[zoumo]

What this PR does / why we need it:
configurable proxy buffers number

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[zoumo]

I signed it

[ElvinEfendi]

@zoumo thanks for working on this! Could you also add e2e tests for both configmap and annotation?

[zoumo]

@ElvinEfendi Should I change the key from proxy-buffer-number to proxy-buffers-number in both annotation and configmap ?

[zoumo]

I have already add e2e tests for annotation in test/e2e/annotations/proxy.go
but I don't known how to add test for configmap

[ElvinEfendi]

Should I change the key from proxy-buffer-number to proxy-buffers-number in both annotation and configmap ?

Yes, please. proxy-buffers-number sounds more correct.

[ElvinEfendi]

I have already add e2e tests for annotation in test/e2e/annotations/proxy.go

You are probably referring to https://github.com/kubernetes/ingress-nginx/pull/3781/files#diff-2917c66c2ab6c97e0d327bc77e023176R151. If you delete all your changes in this PR and run that test, it will still pass. You can set it to something other than default value 4 and adjust the assertion at https://github.com/kubernetes/ingress-nginx/pull/3781/files#diff-2917c66c2ab6c97e0d327bc77e023176R162 accordingly then that will be 👍

but I don't known how to add test for configmap

You can take a look at test/e2e/settings/main_snippet.go for an example. But I don't mind if you skip this, we can add it later.

[zoumo]

@ElvinEfendi
I tried to add e2e test for configmap according to the example in test/e2e/settings/main_snippet.go, but I found that there are too many settings missing. So I gave up and left this work to you :)

[ElvinEfendi]

This is not just about reading the first part, what you're describing proxy_buffer_size

[ElvinEfendi]

/lgtm
/approve

Thanks @zoumo !

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, zoumo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment