-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Opentracing with Datadog - part 2 #3766
Support Opentracing with Datadog - part 2 #3766
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alanjcastonguay please split this PR in two. In the first one change the content of This is because we need to build and publish the nginx image before being able to run the e2e tests |
Thanks for the feedback, @aledbf. All the changes under images/nginx/* were in a single commit 248d9b3, so I cut a new branch from it and created PR #3767, then reverted that commit from here. Added a pair of commits, one to each PR, for a merge conflict - I branched from before 0.76. I am working on the CLA. |
/check-cla |
@alanjcastonguay please squash the commits |
This commit is part 2 of 2, adding configuration of the Datadog Opentracing module to the controller. Fixes half of #3752
/lgtm |
@alanjcastonguay thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanjcastonguay, aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Support Opentracing with Datadog, alongside Zipkin and Jaeger.
libdd_opentracing.so
from source, install it in the nginx container./etc/nginx/opentracing.json
template.Which issue this PR fixes: fixes #3752
Special notes for your reviewer: I didn't sink a lot of time into this. I am open to alternative approaches/implementations, or improvement suggestions.