Add standard labels to namespace specs #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add standard app resource metadata labels to the namespaces specs created when deploying nginx-ingress. Closes kubernetes#3576
k8s-ci-robot
added
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@ddgenome thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ddgenome The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add standard app resource metadata labels to the namespaces specs
created when deploying nginx-ingress.
Closes #3576
What this PR does / why we need it:
This would make it possible to include the nginx-ingress controller in network policy rules, which rely on label selectors for both namespaces and pods, without further manual configuration.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #3576Special notes for your reviewer: