Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix status updated: make sure ingress.status is copied #3569

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
#3474 among other things also changed how we store ingresses - since that PR we clone an Ingress object's attributes selectively and make use of that clone afterwards in the controller. While cloning we missed ing.Status field and status updates relies on this field at

curIPs := ing.Status.LoadBalancer.Ingress
to make a decision whether it should update the status of given ingress. Since we don't copy this field, status updater will always see it as empty and will always try to update redundantly.

This PR fixes the issue by making sure the Status field is copied when we clone Ingress objet.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2018
@k8s-ci-robot k8s-ci-robot requested a review from aledbf December 17, 2018 12:14
@aledbf
Copy link
Member

aledbf commented Dec 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c6629ac into kubernetes:master Dec 17, 2018
@ElvinEfendi ElvinEfendi deleted the fix-status-updater branch December 19, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants