fix status updated: make sure ingress.status is copied #3569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#3474 among other things also changed how we store ingresses - since that PR we clone an Ingress object's attributes selectively and make use of that clone afterwards in the controller. While cloning we missed
ing.Status
field and status updates relies on this field atingress-nginx/internal/ingress/status/status.go
Line 360 in ee3a8fe
This PR fixes the issue by making sure the
Status
field is copied when we clone Ingress objet.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: