Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Tests for getIngressInformation #3566

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Add Unit Tests for getIngressInformation #3566

merged 1 commit into from
Dec 18, 2018

Conversation

diazjf
Copy link

@diazjf diazjf commented Dec 15, 2018

Adds a unit test for the getIngressInformation function.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 15, 2018
@diazjf diazjf force-pushed the unit-locs branch 2 times, most recently from 45ab494 to cb7f397 Compare December 15, 2018 22:43
@diazjf
Copy link
Author

diazjf commented Dec 15, 2018

/test all

@diazjf diazjf force-pushed the unit-locs branch 2 times, most recently from 50e5a11 to 43f2080 Compare December 17, 2018 22:03
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2018
@diazjf diazjf force-pushed the unit-locs branch 2 times, most recently from 919c7a0 to 5a76a86 Compare December 18, 2018 04:45
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2018
@diazjf diazjf force-pushed the unit-locs branch 2 times, most recently from 3947ce2 to 8f2a21d Compare December 18, 2018 05:52
@aledbf
Copy link
Member

aledbf commented Dec 18, 2018

@diazjf besides my equal comment this LGTM

@aledbf aledbf self-assigned this Dec 18, 2018
Add Unit Tests for getIngressInformation
429110a 
Adds a unit test for the getIngressInformation
function.
@aledbf
Copy link
Member

aledbf commented Dec 18, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, diazjf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1b06cf7 into kubernetes:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@antoineco antoineco Awaiting requested review from antoineco

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diazjf @aledbf @k8s-ci-robot