-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore updates of ingresses with invalid class #3532
Conversation
This addresses issues found by race detector.
Passing `k8sStore` by value implies read and copy of `backendConfig`, which is not protected by a mutex and may cause race conditions.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
CLA signed. |
/lgtm |
@ArchangelSDY thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ArchangelSDY The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Ignore updates of ingresses with invalid class. This avoids unnecessary nginx reload which can be really expensive in websocket scenario.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
When I run unit tests, the race detector reports some data races regarding
k8sStore.backendConfig
. I added aRWMutex
to protect against simultaneous read/write of that. In addition, I also changedk8sStore
member functions to receive ak8sStore
pointer rather than a value to avoid copy, which implies read ofbackendConfig
.