-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug with Canary becoming main server #3521
Conversation
/assign @ElvinEfendi |
9b0a7f4
to
d9f0733
Compare
d9f0733
to
1c732d6
Compare
What do you think of filtering out canary ingresses right at the beginning of the function at https://github.com/kubernetes/ingress-nginx/pull/3521/files#diff-86ac9ff9d75a0c5005c116e766a6127dR885? That way we would not have to care about |
@ElvinEfendi that would work too, but I find it less obvious for developers and debugging. |
fcab315
to
ce6f541
Compare
ce6f541
to
af460f7
Compare
/lgtm |
/hold will wait for @clandry94 to 👍 first for me LGTM |
/hold will wait for @clandry94 to 👍 first for me LGTM |
1 similar comment
/hold will wait for @clandry94 to 👍 first for me LGTM |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 these new unit tests give me a lot more confidence too
/hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, wayt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
A canary
Ingress
should never become a catch-all server if no otherIngress
is a catch-all.This PR prevent canary
Ingress
from becoming a catch-all server, or a server with a domain name if no regularIngress
is present.Which issue this PR fixes
Special notes for your reviewer:
Cc @ElvinEfendi @clandry94