Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be consistent with what Nginx supports #3501

Merged
merged 1 commit into from
Dec 2, 2018
Merged

be consistent with what Nginx supports #3501

merged 1 commit into from
Dec 2, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
In https://github.com/kubernetes/ingress-nginx/pull/3409/files we started to apply client_body_buffer_size validator to client_max_body_size directive's value as well. However it turns out client_max_body_size also supports gigabytes using g or G. This introduced and issue #3468 in 0.21.0. In #3492 @aledbf changed the validator to support gigabytes as well, but then it introduces another issue by supporting gigabytes for client_body_buffer_size.

This PR now adds a flag to apply a correct validator for client_body_buffer_size and client_max_body_size instead of applying the same one.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2018
@ElvinEfendi
Copy link
Member Author

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Dec 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 03dba21 into kubernetes:master Dec 2, 2018
@cameracker
Copy link

cameracker commented Jun 3, 2019

Hey guys, thanks for making this change. The removal of this um, semi supported feature did cause an outage for us (not saying this is your fault).

The changelog for the 0.22 release does mention this change, but I would expect this to go under breaking changes because technically this does remove a behavior that was previously available, and requires users to make changes in order to use the new version.

Is there a reason it wasn't included under breaking changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants