be consistent with what Nginx supports #3501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In https://github.com/kubernetes/ingress-nginx/pull/3409/files we started to apply
client_body_buffer_size
validator toclient_max_body_size
directive's value as well. However it turns outclient_max_body_size
also supports gigabytes usingg
orG
. This introduced and issue #3468 in 0.21.0. In #3492 @aledbf changed the validator to support gigabytes as well, but then it introduces another issue by supporting gigabytes forclient_body_buffer_size
.This PR now adds a flag to apply a correct validator for
client_body_buffer_size
andclient_max_body_size
instead of applying the same one.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: