Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baremetal link #3433

Closed
wants to merge 1 commit into from
Closed

Fix baremetal link #3433

wants to merge 1 commit into from

Conversation

ckotzbauer
Copy link

What this PR does / why we need it:

  • Fix broken link in the docs for bare-metal guide.

Which issue this PR fixes: -

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: code-chris
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: elvinefendi

If they are not already assigned, you can assign the PR to them by writing /assign @elvinefendi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckotzbauer
Copy link
Author

signed CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 17, 2018
@ElvinEfendi
Copy link
Member

@code-chris seems like your change is actually breaking a working link, what am I missing?

@ckotzbauer
Copy link
Author

@ElvinEfendi The link points to this address: https://kubernetes.github.io/ingress-nginx/deploy/baremetal.md/
The ".md" is wrong, the page is broken now.

@aledbf
Copy link
Member

aledbf commented Nov 21, 2018

nginx/deploy/baremetal.md/
The ".md" is wrong, the page is broken now.

The real issue here is the / at the end. Please just remove that

@aledbf
Copy link
Member

aledbf commented Nov 22, 2018

Closing. Fixed in #3456

@aledbf aledbf closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants