bugfix: do not merge catch-all canary backends with itself #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @aledbf |
|
@clandry94 can you add a regression test? |
|
@clandry94 friendly ping |
|
Sorry for the delay. I’ll be picking back up on this this week. |
|
/lgtm This seems safe to merge, though it would still be nice to have a regression test. Merging so that we can release it as part of 0.21.0 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clandry94, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't merge yet, I plan on adding a test for this case
What this PR does / why we need it:
If a canary backend is created at the catch all level of the ingress spec, it can merge with itself in some situations. If this happens, then the real backend won't know it exists.
This fixes the problem by iterating over each location at
defServerNameand merges with the first backend which has a server rather than the backend at location 0.