Update cli-arguments.md. Remove tcp and udp, add health-check-timeout. #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
diazjf
reviewed
Nov 2, 2018
docs/user-guide/cli-arguments.md
Outdated
| @@ -19,6 +19,7 @@ They are set in the container spec of the `nginx-ingress-controller` Deployment | |||
| | `--enable-ssl-passthrough` | Enable SSL Passthrough. | | |||
| | `--force-namespace-isolation` | Force namespace isolation. Prevents Ingress objects from referencing Secrets and ConfigMaps located in a different namespace than their own. May be used together with watch-namespace. | | |||
| | `--health-check-path string` | URL path of the health check endpoint. Configured inside the NGINX status server. All requests received on the port defined by the healthz-port parameter are forwarded internally to this path. (default "/healthz") | | |||
| | `--health-check-timeout duration` | Time limit, in seconds, for a probe to health-check-path to succeed. | | |||
There was a problem hiding this comment.
Can you provide the default and format of the duration as well?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@crystaljade thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, crystaljade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded tcp-services-configmap and udp-services-configmap.
Add health-check-timeout.