Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth snippet #3343

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Auth snippet #3343

merged 1 commit into from
Nov 6, 2018

Conversation

abaruni
Copy link

@abaruni abaruni commented Nov 1, 2018

What this PR does / why we need it: Add the ability to specify a custom snippet to use in conjunction with external auth. e.g. adding custom headers to the auth request. Please see #3274

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3274

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2018
@k8s-ci-robot
Copy link
Contributor

@abaruni: GitHub didn't allow me to assign the following users: diazjf.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @diazjf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@diazjf
Copy link

diazjf commented Nov 1, 2018

@abaruni needs e2e tests as well. See https://github.com/kubernetes/ingress-nginx/blob/master/test/e2e/annotations/snippet.go as a sample and make sure to test with multiple lines.

Once added you can test by running FOCUS=<framework-name> make e2e-test. You can add the test to https://github.com/kubernetes/ingress-nginx/blob/master/test/e2e/annotations/auth.go

Also needs some documentation.

@diazjf
Copy link

diazjf commented Nov 1, 2018

Also rebase with master to resolve the tests which are currently failing.

Copy link

@diazjf diazjf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with a few non-critical things to add.

@diazjf
Copy link

diazjf commented Nov 5, 2018

Also make sure to squash into 1 commit.

add test for new auth-snippet annotation

document auth-snippet annotation

add e2e test for auth-snippet annotation

add log warning and update documentation
@aledbf
Copy link
Member

aledbf commented Nov 6, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abaruni, aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Nov 6, 2018

@abaruni thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit d53b492 into kubernetes:master Nov 6, 2018
@abaruni abaruni deleted the auth-snippet branch November 6, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add auth config snippet with new annotation nginx.ingress.kubernetes.io/auth-snippet
4 participants