-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth snippet #3343
Auth snippet #3343
Conversation
@abaruni: GitHub didn't allow me to assign the following users: diazjf. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abaruni needs e2e tests as well. See https://github.com/kubernetes/ingress-nginx/blob/master/test/e2e/annotations/snippet.go as a sample and make sure to test with multiple lines. Once added you can test by running Also needs some documentation. |
Also rebase with master to resolve the tests which are currently failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with a few non-critical things to add.
Also make sure to squash into 1 commit. |
add test for new auth-snippet annotation document auth-snippet annotation add e2e test for auth-snippet annotation add log warning and update documentation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abaruni, aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abaruni thanks! |
What this PR does / why we need it: Add the ability to specify a custom snippet to use in conjunction with external auth. e.g. adding custom headers to the auth request. Please see #3274
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #3274Special notes for your reviewer: