Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code linting #3328

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Code linting #3328

merged 1 commit into from
Oct 31, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 30, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2018
@codecov-io
Copy link

Codecov Report

Merging #3328 into master will increase coverage by 0.08%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3328      +/-   ##
==========================================
+ Coverage   48.33%   48.42%   +0.08%     
==========================================
  Files          75       75              
  Lines        5561     5555       -6     
==========================================
+ Hits         2688     2690       +2     
+ Misses       2527     2521       -6     
+ Partials      346      344       -2
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 63.44% <ø> (+0.77%) ⬆️
internal/ingress/controller/config/config.go 98.41% <100%> (ø) ⬆️
internal/ingress/controller/nginx.go 15.59% <100%> (-0.12%) ⬇️
...ternal/ingress/annotations/backendprotocol/main.go 61.53% <33.33%> (ø) ⬆️
internal/ingress/status/status.go 72.53% <80%> (+0.95%) ⬆️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ceb723...71ebe1c. Read the comment docs.

@ElvinEfendi
Copy link
Member

is there a script to run in the repo for code linting?

@aledbf
Copy link
Member Author

aledbf commented Oct 31, 2018

is there a script to run in the repo for code linting?

No. I use https://github.com/alecthomas/gometalinter/releases running
gometalinter --deadline 300s internal/...

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cb87676 into kubernetes:master Oct 31, 2018
@aledbf aledbf deleted the linit branch October 31, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants