Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for HTTP2 Push Preload annotation #3240

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Adds support for HTTP2 Push Preload annotation #3240

merged 1 commit into from
Dec 24, 2018

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Oct 13, 2018 •
edited
Loading

Signed-off-by: Ricardo Pchevuzinske Katz [email protected]

What this PR does / why we need it: This PR adds support for HTTP2 Push Preload, as specified in issue #3233

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3233

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2018
@rikatz rikatz changed the title [WIP] Adds support for HTTP2 Push Preload annotation Adds support for HTTP2 Push Preload annotation Oct 14, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2018
@rikatz
Copy link
Contributor Author

rikatz commented Oct 14, 2018

Tested, and it works as desired. When putting the annotation nginx.ingress.kubernetes.io/http2-push-preload: "true" the http2_push_preload on; gets inserted into Ingress Location.

Otherwise nothing is inserted

@aledbf
Copy link
Member

aledbf commented Oct 14, 2018

@rikatz please add e2e tests

@rikatz
Copy link
Contributor Author

rikatz commented Oct 14, 2018

@aledbf I've been pretty away, so you mean some e2e here: https://github.com/kubernetes/ingress-nginx/blob/master/test/e2e/annotations/?

I'll take a look into some examples tomorrow :)

@rikatz
Copy link
Contributor Author

rikatz commented Oct 18, 2018

@aledbf Did as asked, but failed in something here. It got me an error here.

Is there something I'm missing?

Thank you!!

@aledbf
Copy link
Member

aledbf commented Dec 22, 2018

@rikatz please rebase

@rikatz rikatz force-pushed the http2-push-preload branch from 4b74faf to 595863f Compare December 23, 2018 18:28
@rikatz
Copy link
Contributor Author

rikatz commented Dec 23, 2018

Rebased, corrected the e2e tests but timeout still happens :(

Need some help to figure out what is going on.

Thanks!

aledbf
aledbf reviewed Dec 23, 2018
View reviewed changes
test/e2e/annotations/http2pushpreload.go Outdated
Set("Host", host).
End()
Expect(errs).Should(BeEmpty())
Expect(resp.StatusCode).Should(Equal(http.StatusNoContent))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be StatusOK

@rikatz rikatz force-pushed the http2-push-preload branch 2 times, most recently from aeb8d7e to 17649b9 Compare December 24, 2018 19:11
@aramase
Adds support for HTTP2 Push Preload annotation
382049a 
update test for backendprotocols

Adds support for HTTP2 Push Preload annotation

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

Adds support for HTTP2 Push Preload annotation

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

Adds support for HTTP2 Push Preload annotation

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

Adds support for HTTP2 Push Preload annotation

Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>

Adds support for HTTP2 Push Preload annotation

Adds support for HTTP2 Push Preload annotation
@rikatz rikatz force-pushed the http2-push-preload branch from 17649b9 to 382049a Compare December 24, 2018 19:13
@aledbf
Copy link
Member

aledbf commented Dec 24, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2018
@aledbf
Copy link
Member

aledbf commented Dec 24, 2018

@rikatz thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit cac694e into kubernetes:master Dec 24, 2018
@rikatz rikatz deleted the http2-push-preload branch December 24, 2018 20:20
@alexkursell alexkursell mentioned this pull request Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@antoineco antoineco Awaiting requested review from antoineco

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for nginx http2_push_preload
4 participants
@rikatz @aledbf @k8s-ci-robot @aramase