Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove annotations grpc-backend and secure-backend already deprecated #3203

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Remove annotations grpc-backend and secure-backend already deprecated #3203

merged 1 commit into from
Oct 9, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 8, 2018

What this PR does / why we need it:

These annotations were deprecated two releases ago. It's time to remove the code.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 8, 2018
@aledbf aledbf force-pushed the remove-deprecated branch 2 times, most recently from b7abcc0 to d8f2a4e Compare October 8, 2018 14:09
@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 8, 2018
@aledbf aledbf force-pushed the remove-deprecated branch 3 times, most recently from c657355 to 7144334 Compare October 8, 2018 14:55
@aledbf aledbf force-pushed the remove-deprecated branch from 7144334 to 859b298 Compare October 8, 2018 15:26
@aledbf
Copy link
Member Author

aledbf commented Oct 8, 2018

@antoineco now it's ready to go

@aledbf aledbf mentioned this pull request Oct 8, 2018
Closed
61 tasks
@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 77aece4 into kubernetes:master Oct 9, 2018
@aledbf aledbf deleted the remove-deprecated branch October 9, 2018 11:17
@aledbf aledbf mentioned this pull request Nov 6, 2018
Closed
@gorshunovr gorshunovr mentioned this pull request Nov 28, 2018
Closed
@aledbf aledbf mentioned this pull request Jan 25, 2019
Closed
@markfermor markfermor mentioned this pull request Feb 4, 2019
Closed
@aledbf aledbf mentioned this pull request Jun 25, 2019
Closed
@ramosbugs ramosbugs mentioned this pull request Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineco antoineco Awaiting requested review from antoineco

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@ElvinEfendi ElvinEfendi

@antoineco antoineco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @antoineco @k8s-ci-robot @ElvinEfendi