Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mainSnippet before events to fix load_module issue. #3170

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

Globegitter
Copy link
Contributor

What this PR does / why we need it:
I was trying to activate the dynamic geoip2 module added in 0.16 as follows:

main-snippet: |
    load_module /etc/nginx/modules/ngx_http_geoip2_module.so;

but then getting the error:

Error: exit status 1
nginx-ingress-controller 2018/10/02 13:24:16 [emerg] 21791#21791: "load_module" directive is specified too late in /tmp/nginx-cfg246481140:21
nginx-ingress-controller nginx: [emerg] "load_module" directive is specified too late in /tmp/nginx-cfg246481140:21
nginx-ingress-controller nginx: configuration file /tmp/nginx-cfg246481140 test failed

And turns out the load_module commands need to be listed before the event block.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2018
@aledbf
Copy link
Member

aledbf commented Oct 8, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Globegitter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Oct 8, 2018

@Globegitter thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 182767b into kubernetes:master Oct 8, 2018
@Globegitter Globegitter deleted the move-mainsnippet branch October 16, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants