Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update name of config map in README.md #3162

Merged
merged 1 commit into from
Sep 30, 2018

Conversation

ms4720
Copy link
Contributor

@ms4720 ms4720 commented Sep 30, 2018

What this PR does / why we need it:

  • updates the name of the ingress nginx configure CM to current name

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

fixes #3161

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2018
@aledbf
Copy link
Member

aledbf commented Sep 30, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2018
@aledbf
Copy link
Member

aledbf commented Sep 30, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ms4720

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Sep 30, 2018

@ms4720 thanks!

@k8s-ci-robot k8s-ci-robot merged commit 9146cfb into kubernetes:master Sep 30, 2018
@ms4720
Copy link
Contributor Author

ms4720 commented Sep 30, 2018

@aledbf glad to help

@ms4720
Copy link
Contributor Author

ms4720 commented Oct 2, 2018

@aledbf what does added to.project mean?

Thanks

@aledbf
Copy link
Member

aledbf commented Oct 2, 2018

what does added to.project mean?

Indicates in which development cycle is included (for release notes https://github.com/kubernetes/ingress-nginx/projects/27)

@ms4720 ms4720 deleted the ms4720-patch-1 branch October 5, 2018 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong config map name in docs/examples/customization/custom-configuration/README.md
3 participants