-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document when to modify ELB idle timeouts and set default value to 60s #3046
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/check-cla |
/assign @aledbf |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, mootpt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mootpt thanks! |
sure thing |
What this PR does / why we need it:
This PR changes the default ELB idle timeout in the manifest to 60s. This is to allow connections to be properly closed by the ELB. By default, the NGINX
keepalive_timeout
is set to75s
and with the existing config of3600s
the ELB attempts to reuse closed connections.Here is a link to the official AWS documentation that covers idle timeouts.
Special notes for your reviewer:
Slack thread: https://kubernetes.slack.com/archives/CANQGM8BA/p1536105979000100
The example in the Helm chart will also likely need to be updated
Please feel free to amend as necessary.