Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for enable-dynamic-certificates feature #2983

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

hnrytrn
Copy link
Contributor

@hnrytrn hnrytrn commented Aug 24, 2018

What this PR does / why we need it:

Adds documentation for dynamic certificate serving feature.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2018
@codecov-io
Copy link

Codecov Report

Merging #2983 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2983   +/-   ##
=======================================
  Coverage   47.54%   47.54%           
=======================================
  Files          77       77           
  Lines        5639     5639           
=======================================
  Hits         2681     2681           
  Misses       2605     2605           
  Partials      353      353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72112fe...0af9d5b. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 24, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, hnrytrn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2018
@aledbf
Copy link
Member

aledbf commented Aug 24, 2018

@hnrytrn thanks for the this feature and the docs

@k8s-ci-robot k8s-ci-robot merged commit a363450 into kubernetes:master Aug 24, 2018
@ElvinEfendi ElvinEfendi deleted the dynamic-cert-docs branch August 24, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants