Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update labels #2970

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Update labels #2970

merged 1 commit into from
Aug 22, 2018

Conversation

ant31
Copy link
Member

@ant31 ant31 commented Aug 22, 2018

fixes #2969
Update labels to follow the guidelines from k8s.io

cc @mattfarina

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2018
@ant31
Copy link
Member Author

ant31 commented Aug 22, 2018

@aledbf
I'm not very familiar with this repo, so I may have missed some resources.

@ant31 ant31 mentioned this pull request Aug 22, 2018
Closed
@codecov-io
Copy link

Codecov Report

Merging #2970 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2970   +/-   ##
=======================================
  Coverage   47.58%   47.58%           
=======================================
  Files          77       77           
  Lines        5634     5634           
=======================================
  Hits         2681     2681           
  Misses       2600     2600           
  Partials      353      353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a426fba...0a88be3. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 22, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ant31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit a2e8bd8 into kubernetes:master Aug 22, 2018
@aledbf
Copy link
Member

aledbf commented Aug 22, 2018

@ant31 thanks!

@martinitus
Copy link

Note, this did "break the documentation" in https://github.com/kubernetes/ingress-nginx/blob/master/docs/deploy/index.md#verify-installation and below. Will try to provide a fix.

@martinitus martinitus mentioned this pull request Aug 28, 2018
Closed
@hswong3i hswong3i mentioned this pull request Sep 4, 2018
Merged
hswong3i added a commit to alvistack/kubernetes-ingress-nginx that referenced this pull request Sep 5, 2018
@hswong3i
Fixup kubernetes#2970: Add Missing Label `app.kubernetes.io/part-of: …
6d3e9ea 
…ingress-nginx`

-    Add missing label `app.kubernetes.io/part-of: ingress-nginx` for deploy example
-    Update new labels for docs/deploy and docs/examples
-    Update new labels for test/e2e and test/manifests
-    Update new labels for images/nginx

Also close kubernetes#3001
k8s-ci-robot added a commit that referenced this pull request Sep 5, 2018
@k8s-ci-robot
Merge pull request #3035 from alvistack/2970-fixup
d0acf91 
Fixup #2970: Add Missing Label `app.kubernetes.io/part-of: ingress-nginx`
@mdgreenwald
Copy link

Just connecting some dots for posterity:
The commit:
0a88be3
k8s.io reference docs:
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uses recommended labels
6 participants
@ant31 @codecov-io @aledbf @k8s-ci-robot @martinitus @mdgreenwald