-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in flags.go #2932
Fixed typo in flags.go #2932
Conversation
ssl-passthrough-proxy-port
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/check-cla |
Codecov Report
@@ Coverage Diff @@
## master #2932 +/- ##
=======================================
Coverage 47.56% 47.56%
=======================================
Files 77 77
Lines 5531 5531
=======================================
Hits 2631 2631
Misses 2560 2560
Partials 340 340
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, onesolpark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@onesolpark thanks! |
Noticed a small typo while changing different configs for ssl-passthrough.
Flags.go, ssl-passtrough-proxy-port -> ssl-passthrough-proxy-port.
What this PR does / why we need it:
Fixed typo in flags.go (ssl-passthrough-proxy-port)
Special notes for your reviewer:
Not really a bug or anything but I guess I had to let you know just in case.