-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grafana] Rate over 2 minutes since default Prometheus interval is 1m #2884
Conversation
@discordianfish WDYT about this? |
2m might be a better default, that's right. Even better though would be using $__interval and rate() instead of irate(). This has it's own problems though: grafana/grafana#11451 |
I resolved the conflicts in the latest commit. I would suggest to move forward with this and see how the discussion with |
Codecov Report
@@ Coverage Diff @@
## master #2884 +/- ##
==========================================
- Coverage 47.58% 47.54% -0.04%
==========================================
Files 77 76 -1
Lines 5634 5483 -151
==========================================
- Hits 2681 2607 -74
+ Misses 2600 2542 -58
+ Partials 353 334 -19
Continue to review full report at Codecov.
|
/lgtm |
@Miouge1 thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Prometheus' default
scrape_interval
is1m
, see prometheus doc, makingirate(mymetrics{}[1m])
not return any data with the defaultscrape_interval
.In order to make this Grafana dashboard as easy to use as possible I think it should work out of the box with the Prometheus defaults, therefore I suggest to switch
1m
for2m
but other values could also be useful.Special notes for your reviewer:
Example: prometheus/prometheus#3194