Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor entrypoint to avoid issues with volumes #2877

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Refactor entrypoint to avoid issues with volumes #2877

merged 1 commit into from
Jul 30, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 30, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2018
@codecov-io
Copy link

Codecov Report

Merging #2877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2877   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files          76       76           
  Lines        5483     5483           
=======================================
  Hits         2608     2608           
  Misses       2540     2540           
  Partials      335      335

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71abdf7...69a2a27. Read the comment docs.

ElvinEfendi
ElvinEfendi reviewed Jul 30, 2018
View reviewed changes
rootfs/entrypoint.sh
/tmp \
/var/log
/var/log/nginx
/tmp
Copy link
Member

@ElvinEfendi ElvinEfendi Jul 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we leaving these last three folders here while we remove the others?

Copy link
Member Author

@aledbf aledbf Jul 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because entrypoint.sh runs at startup and the removed items from a list could be a volume and clean-install removes temporal paths

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 06db4b0 into kubernetes:master Jul 30, 2018
@aledbf aledbf mentioned this pull request Jul 30, 2018
Closed
@aledbf aledbf deleted the change-starup branch July 30, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi ElvinEfendi left review comments

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @codecov-io @ElvinEfendi @k8s-ci-robot