-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug with lua e2e test suite #2867
Conversation
} | ||
return strings.Contains(cfg, "configuration.nameservers = { "+strings.Join(ips, ", ")+" }") | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can see I wasn't asserting on err
here and the check was timing out (because the condition never matches, executing dns.GetSystemNameServers()
returns resolvers for the current host not for the running pod) silently after 5 minutes, and this was happening before every test. Therefore e2e test runtime doubled.
/assign @aledbf |
Codecov Report
@@ Coverage Diff @@
## master #2867 +/- ##
=======================================
Coverage 47.71% 47.71%
=======================================
Files 75 75
Lines 5434 5434
=======================================
Hits 2593 2593
Misses 2510 2510
Partials 331 331 Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: