Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with lua e2e test suite #2867

Merged
merged 1 commit into from
Jul 28, 2018
Merged

fix bug with lua e2e test suite #2867

merged 1 commit into from
Jul 28, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2018
}
return strings.Contains(cfg, "configuration.nameservers = { "+strings.Join(ips, ", ")+" }")
})

Copy link
Member Author

@ElvinEfendi ElvinEfendi Jul 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see I wasn't asserting on err here and the check was timing out (because the condition never matches, executing dns.GetSystemNameServers() returns resolvers for the current host not for the running pod) silently after 5 minutes, and this was happening before every test. Therefore e2e test runtime doubled.

@ElvinEfendi
Copy link
Member Author

/assign @aledbf
/assign @antoineco

@codecov-io
Copy link

Codecov Report

Merging #2867 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2867   +/-   ##
=======================================
  Coverage   47.71%   47.71%           
=======================================
  Files          75       75           
  Lines        5434     5434           
=======================================
  Hits         2593     2593           
  Misses       2510     2510           
  Partials      331      331

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45ba167...fa74877. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jul 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 002379b into kubernetes:master Jul 28, 2018
@ElvinEfendi ElvinEfendi deleted the fix-lua-e2e branch July 28, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants