Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #2866

Merged
merged 1 commit into from
Jul 28, 2018
Merged

Update index.md #2866

merged 1 commit into from
Jul 28, 2018

Conversation

lvthillo
Copy link
Contributor

docker for mac is now officially supported by Docker 18.06.0 (Since I was struggling with the squash on a PR a new one..)

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

docker for mac is now officially supported by Docker 18.06.0 (Since I was struggling with the squash on a PR a new one..)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2018
@antoineco
Copy link
Contributor

/lgtm
Sorry for the trouble with the previous squash :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, lvthillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #2866 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
+ Coverage   47.69%   47.71%   +0.01%     
==========================================
  Files          75       75              
  Lines        5434     5434              
==========================================
+ Hits         2592     2593       +1     
+ Misses       2512     2510       -2     
- Partials      330      331       +1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a30ea...91675b3. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 9e2cc65 into kubernetes:master Jul 28, 2018
@lvthillo lvthillo deleted the patch-2 branch July 28, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants