Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use resty-cli for running lua unit tests #2829

Merged
merged 1 commit into from
Jul 21, 2018
Merged

use resty-cli for running lua unit tests #2829

merged 1 commit into from
Jul 21, 2018

Conversation

ElvinEfendi
Copy link
Member

@ElvinEfendi ElvinEfendi commented Jul 21, 2018

What this PR does / why we need it:
This way we will run Lua tests inside a headless Nginx process. That means we won't have to mock most of the dependencies and the test environment will be very close to production environment.
resty-cli runs the Lua code in timer phase so only the APIs that aren't available in timer phase won't be available.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2018
@ElvinEfendi
Copy link
Member Author

/assign @aledbf
/assign @antoineco

@aledbf
Copy link
Member

aledbf commented Jul 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #2829 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2829   +/-   ##
=======================================
  Coverage   47.34%   47.34%           
=======================================
  Files          75       75           
  Lines        5413     5413           
=======================================
  Hits         2563     2563           
  Misses       2525     2525           
  Partials      325      325

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeae20c...5c18fc9. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit f5963f2 into kubernetes:master Jul 21, 2018
@ElvinEfendi ElvinEfendi deleted the use-resty-cli branch July 22, 2018 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants