Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setcap from image and update nginx to 0.15.1 #2826

Merged
merged 1 commit into from
Jul 21, 2018
Merged

Remove setcap from image and update nginx to 0.15.1 #2826

merged 1 commit into from
Jul 21, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 21, 2018 •
edited
Loading

fixes #2801

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2018
@codecov-io
Copy link

codecov-io commented Jul 21, 2018 •
edited
Loading

Codecov Report

Merging #2826 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2826   +/-   ##
=======================================
  Coverage   47.33%   47.33%           
=======================================
  Files          75       75           
  Lines        5413     5413           
=======================================
  Hits         2562     2562           
  Misses       2527     2527           
  Partials      324      324

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237dcd7...5ff443e. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2018
@aledbf aledbf changed the title WIP: Remove setcap from image and update nginx to 0.15.1 Remove setcap from image and update nginx to 0.15.1 Jul 21, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2018
@aledbf
Copy link
Member Author

aledbf commented Jul 21, 2018

Merging to build and test the ingress controller

@aledbf aledbf merged commit aeae20c into kubernetes:master Jul 21, 2018
@aledbf aledbf deleted the update-nginx branch July 22, 2018 01:12
@aledbf aledbf mentioned this pull request Jul 27, 2018
Closed
@aledbf aledbf mentioned this pull request Aug 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ElvinEfendi ElvinEfendi

@antoineco antoineco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zipkin opentracing broken in 0.17.0, 0.17.1
5 participants
@aledbf @k8s-ci-robot @codecov-io @ElvinEfendi @antoineco