Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of how we run as user #2825

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 21, 2018

Test image: quay.io/aledbf/nginx-ingress-controller:0.401

fixes #2781

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2018
@aledbf
Copy link
Member Author

aledbf commented Jul 21, 2018

@antoineco please check the wip (only the test if we can run setcap and run as root it's missing)

@aledbf aledbf force-pushed the update-image branch 2 times, most recently from 5f2c1c5 to d3eb3ad Compare July 21, 2018 03:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2018
@codecov-io
Copy link

Codecov Report

Merging #2825 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2825   +/-   ##
=======================================
  Coverage   47.34%   47.34%           
=======================================
  Files          75       75           
  Lines        5413     5413           
=======================================
  Hits         2563     2563           
  Misses       2525     2525           
  Partials      325      325

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeae20c...7210518. Read the comment docs.

@aledbf aledbf changed the title WIP: Refactoring how we run as user Refactoring of how we run as user Jul 21, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2018
@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 43aabfc into kubernetes:master Jul 22, 2018
@aledbf aledbf deleted the update-image branch July 22, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingress-nginx > 0.16.x does not support aufs anymore
5 participants