Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple optimizations to build targets #2823

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Multiple optimizations to build targets #2823

merged 1 commit into from
Jul 20, 2018

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Jul 20, 2018

What this PR does / why we need it:

  • Clean up e2e test on interruption
    Currently, interrupting Ginkgo does not clean up the namespaces created as part of the e2e tests.
  • Leverage GOCACHE for faster builds
    Speeds up Docker-based builds significantly.
  • Forward container STDIN in make targets
    Actually do something when the user presses Ctrl+C.

/assign @aledbf @ElvinEfendi

* Clean up e2e test on interruption
* Leverage GOCACHE for faster builds
* Forward container STDIN in make targets
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2018
@aledbf
Copy link
Member

aledbf commented Jul 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Jul 20, 2018

@antoineco thanks!

@codecov-io
Copy link

Codecov Report

Merging #2823 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
+ Coverage   47.34%   47.45%   +0.11%     
==========================================
  Files          75       75              
  Lines        5413     5413              
==========================================
+ Hits         2563     2569       +6     
+ Misses       2525     2521       -4     
+ Partials      325      323       -2
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️
cmd/nginx/main.go 11.18% <0%> (+4.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e211101...0c7b948. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 7784d73 into kubernetes:master Jul 20, 2018
@antoineco antoineco deleted the e2e-aftersuite-clean-up branch July 20, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants