Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana Dashboard #2771

Merged
merged 3 commits into from
Jul 14, 2018
Merged

Grafana Dashboard #2771

merged 3 commits into from
Jul 14, 2018

Conversation

Stono
Copy link
Contributor

@Stono Stono commented Jul 11, 2018

This PR containers a Grafana dashboard for the metrics in #2726

It contains:

  • Ability to filter by Namespace, Controller Class and Controller
  • Visbility of Request Volume, connections, success rates, config reloads and configs out of sync.
  • Network IO pressure, memory and CPU use
  • Ingress P50, P95 and P99 percentile response times with IN/OUT throughput
  • SSL certificate expiry
  • Annotational overlays to show when config reloads happened

It looks like this:
screen shot 2018-07-11 at 14 24 07

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2018
@jpds
Copy link

jpds commented Jul 11, 2018

Can you please make the datasource for this dashboard a variable? I have two prometheus servers as I run them in different AZs.

@codecov-io
Copy link

Codecov Report

Merging #2771 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2771   +/-   ##
=======================================
  Coverage   40.87%   40.87%           
=======================================
  Files          73       73           
  Lines        5108     5108           
=======================================
  Hits         2088     2088           
  Misses       2731     2731           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd2c5e...1cb52d2. Read the comment docs.

@jpds
Copy link

jpds commented Jul 11, 2018

Also, on the default scrape interval of 60s, a lot of the charts don't display.

@jpds
Copy link

jpds commented Jul 11, 2018

A metric I've found useful is:

sum(rate(nginx_ingress_controller_requests[2m])) by (ingress, status)

@Stono
Copy link
Contributor Author

Stono commented Jul 11, 2018 via email

@aledbf
Copy link
Member

aledbf commented Jul 12, 2018

@Stono can you check the name of the metrics (s/seconds/milliseconds) and then we are ready to merge

@aledbf
Copy link
Member

aledbf commented Jul 12, 2018

@jpds let's get this merge and then we can improve the dashboard (PRs are always welcomed)

@aledbf aledbf mentioned this pull request Jul 12, 2018
@aledbf
Copy link
Member

aledbf commented Jul 14, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Stono

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9b6d230 into kubernetes:master Jul 14, 2018
@erik-stephens
Copy link

Not sure if this is "new issue" worthy. Wanted to mention that exporting dashboards from grafana automatically provides a facility for making the data sources portable (at least with the grafana 5.x that we're using). I don't know how this was created to not have those templated. Will trip others up when trying to import it.

@jmreicha
Copy link

jmreicha commented Jul 24, 2018

Getting a Datasoure named Prometheus was not found error in Grafana (5.1.3) when I try to import this dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants