-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grafana Dashboard #2771
Grafana Dashboard #2771
Conversation
Can you please make the datasource for this dashboard a variable? I have two prometheus servers as I run them in different AZs. |
Codecov Report
@@ Coverage Diff @@
## master #2771 +/- ##
=======================================
Coverage 40.87% 40.87%
=======================================
Files 73 73
Lines 5108 5108
=======================================
Hits 2088 2088
Misses 2731 2731
Partials 289 289 Continue to review full report at Codecov.
|
Also, on the default scrape interval of 60s, a lot of the charts don't display. |
A metric I've found useful is:
|
I can't really adjust it for everyone's use case. You're going to have to
make tweaks for your environment when you import it.
…On Wed, 11 Jul 2018, 3:00 pm Codecov, ***@***.***> wrote:
Codecov
<https://codecov.io/gh/kubernetes/ingress-nginx/pull/2771?src=pr&el=h1>
Report
Merging #2771
<https://codecov.io/gh/kubernetes/ingress-nginx/pull/2771?src=pr&el=desc>
into master
<https://codecov.io/gh/kubernetes/ingress-nginx/commit/bdd2c5e3be9c1d431ca5f743591f1520cca7d9ce?src=pr&el=desc>
will *not change* coverage.
The diff coverage is n/a.
[image: Impacted file tree graph]
<https://codecov.io/gh/kubernetes/ingress-nginx/pull/2771?src=pr&el=tree>
@@ Coverage Diff @@## master #2771 +/- ##
=======================================
Coverage 40.87% 40.87%
=======================================
Files 73 73
Lines 5108 5108
=======================================
Hits 2088 2088
Misses 2731 2731
Partials 289 289
------------------------------
Continue to review full report at Codecov
<https://codecov.io/gh/kubernetes/ingress-nginx/pull/2771?src=pr&el=continue>
.
*Legend* - Click here to learn more
<https://docs.codecov.io/docs/codecov-delta>
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov
<https://codecov.io/gh/kubernetes/ingress-nginx/pull/2771?src=pr&el=footer>.
Last update bdd2c5e...1cb52d2
<https://codecov.io/gh/kubernetes/ingress-nginx/pull/2771?src=pr&el=lastupdated>.
Read the comment docs <https://docs.codecov.io/docs/pull-request-comments>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2771 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABaviaNGk9JuSw3zb2Z8t7QdgEaa5lyeks5uFgUNgaJpZM4VLJp1>
.
|
@Stono can you check the name of the metrics (s/seconds/milliseconds) and then we are ready to merge |
@jpds let's get this merge and then we can improve the dashboard (PRs are always welcomed) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, Stono The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not sure if this is "new issue" worthy. Wanted to mention that exporting dashboards from grafana automatically provides a facility for making the data sources portable (at least with the grafana 5.x that we're using). I don't know how this was created to not have those templated. Will trip others up when trying to import it. |
Getting a |
This PR containers a Grafana dashboard for the metrics in #2726
It contains:
It looks like this: