Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for Client-Body-Buffer-Size #2727

Merged
merged 1 commit into from
Jul 1, 2018

Conversation

diazjf
Copy link

@diazjf diazjf commented Jul 1, 2018

Adds test cases for the client-body-buffer-size annotation.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2018
Adds test cases for the client-body-buffer-size annotation.
@codecov-io
Copy link

Codecov Report

Merging #2727 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2727      +/-   ##
==========================================
- Coverage    41.1%   40.96%   -0.14%     
==========================================
  Files          72       72              
  Lines        5085     5085              
==========================================
- Hits         2090     2083       -7     
- Misses       2707     2713       +6     
- Partials      288      289       +1
Impacted Files Coverage Δ
cmd/nginx/main.go 22.62% <0%> (-5.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e68be3...6b5e383. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jul 1, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2018
@aledbf
Copy link
Member

aledbf commented Jul 1, 2018

@diazjf thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, diazjf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 92474ed into kubernetes:master Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants