Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample rate configmap option for zipkin in nginx-opentracing #2719

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

gugu
Copy link
Contributor

@gugu gugu commented Jun 28, 2018

What this PR does / why we need it:

Currently it is not possible to specify sample rate for zipkin in opentracing plugin, which would be really usable as ingress is a first entrypoint in whole microservice chain

This pull request adds an option zipkin-sample-rate in ConfigMap

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2018
@codecov-io
Copy link

Codecov Report

Merging #2719 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2719      +/-   ##
==========================================
+ Coverage   40.95%   40.96%   +0.01%     
==========================================
  Files          72       72              
  Lines        5084     5085       +1     
==========================================
+ Hits         2082     2083       +1     
  Misses       2713     2713              
  Partials      289      289
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 10.93% <ø> (ø) ⬆️
internal/ingress/controller/config/config.go 98.24% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c5d77...bc53d1e. Read the comment docs.

@gugu
Copy link
Contributor Author

gugu commented Jun 28, 2018

/assign @bowei

@aledbf
Copy link
Member

aledbf commented Jun 28, 2018

@gugu please don't assign approvers manually

@aledbf
Copy link
Member

aledbf commented Jun 28, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2018
@aledbf
Copy link
Member

aledbf commented Jun 28, 2018

@gugu thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, gugu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6e68be3 into kubernetes:master Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants