Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial read of configuration configmap #2692

Merged
merged 1 commit into from
Jun 23, 2018
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 23, 2018

Which issue this PR fixes: fixes #2689

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2018
@aledbf aledbf merged commit 0951b97 into kubernetes:master Jun 23, 2018
@codecov-io
Copy link

Codecov Report

Merging #2692 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
+ Coverage   40.96%   40.97%   +0.01%     
==========================================
  Files          72       72              
  Lines        5080     5081       +1     
==========================================
+ Hits         2081     2082       +1     
  Misses       2712     2712              
  Partials      287      287
Impacted Files Coverage Δ
internal/ingress/controller/store/store.go 58.85% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b22e6...75abdc0. Read the comment docs.

@aledbf aledbf deleted the cm branch June 23, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error reading ConfigMap
3 participants