-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update opentracing configuration #2676
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7ebf8c9
to
2293651
Compare
b7241f0
to
d34523f
Compare
@aledbf - for propagating the context, now, you have to use the opentracing_propagate_context directive. It implements this suggestion from nginx-devel. |
d34523f
to
50b5652
Compare
@rnburn added. Do you have any other suggestion? |
I think support for embedded configurations where the the tracer's configuration is passed through the ingress configuration would be a good idea, since then you can support all the options without requiring code for each one. But that's something I can follow up with in a later PR. |
Codecov Report
@@ Coverage Diff @@
## master #2676 +/- ##
==========================================
- Coverage 40.93% 40.88% -0.06%
==========================================
Files 72 72
Lines 5088 5085 -3
==========================================
- Hits 2083 2079 -4
- Misses 2721 2723 +2
+ Partials 284 283 -1
Continue to review full report at Codecov.
|
Which issue this PR fixes: fixes #2222