Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentracing configuration #2676

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 21, 2018

Which issue this PR fixes: fixes #2222

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2018
@aledbf aledbf added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2018
@aledbf aledbf force-pushed the opentracing-update branch from 7ebf8c9 to 2293651 Compare June 21, 2018 16:34
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2018
@aledbf aledbf force-pushed the opentracing-update branch 2 times, most recently from b7241f0 to d34523f Compare June 21, 2018 20:49
@rnburn
Copy link
Contributor

rnburn commented Jun 21, 2018

@aledbf - for propagating the context, now, you have to use the opentracing_propagate_context directive.

It implements this suggestion from nginx-devel.

@aledbf aledbf force-pushed the opentracing-update branch from d34523f to 50b5652 Compare June 21, 2018 21:04
@aledbf
Copy link
Member Author

aledbf commented Jun 21, 2018

@rnburn added. Do you have any other suggestion?
Thanks for watching this PR

@rnburn
Copy link
Contributor

rnburn commented Jun 21, 2018

I think support for embedded configurations where the the tracer's configuration is passed through the ingress configuration would be a good idea, since then you can support all the options without requiring code for each one.

But that's something I can follow up with in a later PR.

@aledbf aledbf removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2018
@codecov-io
Copy link

Codecov Report

Merging #2676 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2676      +/-   ##
==========================================
- Coverage   40.93%   40.88%   -0.06%     
==========================================
  Files          72       72              
  Lines        5088     5085       -3     
==========================================
- Hits         2083     2079       -4     
- Misses       2721     2723       +2     
+ Partials      284      283       -1
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 66.52% <0%> (+2.58%) ⬆️
internal/ingress/controller/nginx.go 10.93% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1841815...50b5652. Read the comment docs.

@aledbf aledbf merged commit df76d4b into kubernetes:master Jun 21, 2018
@aledbf aledbf deleted the opentracing-update branch June 21, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfault due to opentracing
4 participants