-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After a configmap change parse ingress annotations (again) #2672
Conversation
continue | ||
} | ||
store.extractAnnotations(ing) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledbf did you see #2656 (comment)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElvinEfendi yes, please check my comment
Codecov Report
@@ Coverage Diff @@
## master #2672 +/- ##
==========================================
- Coverage 40.88% 40.82% -0.07%
==========================================
Files 72 72
Lines 5070 5078 +8
==========================================
Hits 2073 2073
- Misses 2715 2723 +8
Partials 282 282
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue this PR fixes:
fixes #2567