Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for proxy-cookie-domain annotation (#2034) #2666

Merged

Conversation

jstoja
Copy link
Contributor

@jstoja jstoja commented Jun 19, 2018

Documentation for proxy-cookie-domain annotation was missing.
This fixes #2034 and solves the answers of @aledbf .

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2018
@jstoja
Copy link
Contributor Author

jstoja commented Jun 19, 2018

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Jun 19, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2018
@aledbf
Copy link
Member

aledbf commented Jun 19, 2018

@jstoja thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, jstoja

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2018
@codecov-io
Copy link

Codecov Report

Merging #2666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2666   +/-   ##
=======================================
  Coverage   40.84%   40.84%           
=======================================
  Files          72       72           
  Lines        5073     5073           
=======================================
  Hits         2072     2072           
  Misses       2718     2718           
  Partials      283      283

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a80d215...0cfd6dc. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 7220277 into kubernetes:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make proxy_cookie_domain configurable as an annotation
4 participants