Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a unix socket instead udp for reception of metrics #2652

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Use a unix socket instead udp for reception of metrics #2652

merged 1 commit into from
Jun 17, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 16, 2018

No description provided.

@aledbf aledbf added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 16, 2018
@codecov-io
Copy link

codecov-io commented Jun 16, 2018 •
edited
Loading

Codecov Report

Merging #2652 into master will decrease coverage by 0.03%.
The diff coverage is 23.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   40.75%   40.71%   -0.04%     
==========================================
  Files          74       73       -1     
  Lines        5077     5074       -3     
==========================================
- Hits         2069     2066       -3     
  Misses       2726     2726              
  Partials      282      282
Impacted Files Coverage Δ
cmd/nginx/main.go 22.62% <0%> (ø) ⬆️
internal/ingress/metric/collector/collector.go 3.03% <27.77%> (ø)
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7625b...ee3c586. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jun 16, 2018

@fmejia97 @andrewlouis93 ping

andrewloux
andrewloux reviewed Jun 17, 2018
View reviewed changes
Copy link
Contributor

@andrewloux andrewloux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some comments to update, but otherwise looks great. Thanks for doing this :)

internal/ingress/metric/collector/collector.go Outdated

const packetSize = 1024 * 65

// handleMessages process packets received in an UDP connection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update this comment to omit UDP.

Here's some other places as well:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@andrewloux
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, andrewlouis93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf merged commit c4ec773 into kubernetes:master Jun 17, 2018
@aledbf aledbf deleted the prometheus branch June 17, 2018 17:32
fmejia97 pushed a commit to Shopify/ingress that referenced this pull request Jun 18, 2018
@aledbf @fmejia97
Use a unix socket instead udp for reception of metrics (kubernetes#2652)
e0ed8e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewloux andrewloux andrewloux left review comments

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledbf @codecov-io @andrewloux @k8s-ci-robot @ElvinEfendi